Review Request 118415: Fix looking up icons

[Bhushan Shah]

> On May 30, 2014, 4:10 p.m., Christoph Feck wrote:
> > Good catch, merci! Any chance this fixes bug 330845?
> 
> Martin Klapetek wrote:
>     Yup, it does. I had Eike especially test this for his comment #2 on that bug, he says this fixes the problem :)

This fixes bug indeed but scales up icons which is really bad..

For example, largest icon size available is 22 and if one ask for 1600x1600 we scale up 22x22 icon to requested size and return it. I tried changing it but resulting this test fails,

        pix = iconLoader.loadIcon("#crazyname", KIconLoader::NoGroup, 1600);
        QVERIFY(!pix.isNull());
        QCOMPARE(pix.size(), QSize(1600, 1600));

So I am not sure if that behavior is correct or not?


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/#review58781
-----------------------------------------------------------


On May 30, 2014, 1:53 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118415/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 1:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> What the current code does is looking for the best match, storing it into QString path...and then overwrite it with empty string on next run if the icon is not found in the current dir. So we need to check first if the icon is available in the theme and only then store the path, otherwise empty string gets returned non-deterministically.
> 
> This also fixes case of some missing icons in Plasma Next.
> 
> 
> Diffs
> -----
> 
>   src/kicontheme.cpp 78b8485 
> 
> Diff: https://git.reviewboard.kde.org/r/118415/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140530/12d4ff83/attachment.html>