Review Request 118415: Fix looking up icons

Martin Klapetek martin.klapetek at gmail.com
Fri May 30 08:23:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/
-----------------------------------------------------------

Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
-------

What the current code does is looking for the best match, storing it into QString path...and then overwrite it with empty string on next run if the icon is not found in the current dir. So we need to check first if the icon is available in the theme and only then store the path, otherwise empty string gets returned non-deterministically.

This also fixes case of some missing icons in Plasma Next.


Diffs
-----

  src/kicontheme.cpp 78b8485 

Diff: https://git.reviewboard.kde.org/r/118415/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140530/ae0830ed/attachment.html>


More information about the Kde-frameworks-devel mailing list