Review Request 118234: [frameworksintegration] Ensure the xcb connection gets flushed before the event dispatcher blocks

Martin Gräßlin mgraesslin at kde.org
Fri May 30 06:15:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118234/
-----------------------------------------------------------

(Updated May 30, 2014, 8:15 a.m.)


Review request for KDE Frameworks and Àlex Fiestas.


Changes
-------

* moved the find_package(xcb) into the not-apple part
* made it recommended dependency


Bugs: 334858
    https://bugs.kde.org/show_bug.cgi?id=334858


Repository: frameworkintegration


Description
-------

Ensure the xcb connection gets flushed before the event dispatcher blocks

This is a workaround for Qt versions which do not yet have the change
https://codereview.qt-project.org/85654

It is important to have this workaround as applications can get stalled
when a framework uses xcb and doesn't flush the connection manually.

BUG: 334858


Diffs (updated)
-----

  src/platformtheme/main.cpp 21d9aa0864e1887f5efbe4a05d264968af6e7e73 
  src/platformtheme/config-platformtheme.h.cmake PRE-CREATION 
  src/platformtheme/CMakeLists.txt da77cf816fe5f63e8eb9277d5d81d957b89c7966 

Diff: https://git.reviewboard.kde.org/r/118234/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140530/1d7b8c0e/attachment.html>


More information about the Kde-frameworks-devel mailing list