Review Request 118128: Use actual bytes formatter for sizes in KDirModel

Martin Klapetek martin.klapetek at gmail.com
Thu May 29 17:00:09 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118128/
-----------------------------------------------------------

(Updated May 29, 2014, 7 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Use no formatting at all, returns qulonglong bytes.


Repository: kio


Description
-------

Now I'm not sure if returning the unit together with the size won't break some things, but as it returns string already, I thought returning it in the "human readable" form would be better than always returning bytes.


Diffs (updated)
-----

  src/widgets/kdirmodel.cpp 70d5ee4 

Diff: https://git.reviewboard.kde.org/r/118128/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140529/4f024c65/attachment.html>


More information about the Kde-frameworks-devel mailing list