Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

Matthew Dawson matthew at mjdsystems.ca
Thu May 29 16:49:25 UTC 2014



> On May 29, 2014, 10:57 a.m., David Edmundson wrote:
> > This doesn't look great to me.
> > We'd have to release another 4.x.

Is this too big for the KDE 4.13.x releases?  It doesn't change the default behaviour, and as discussed in: https://git.reviewboard.kde.org/r/115602/ , this is the only way to have a kactivities installed from both the KDE4 releases and frameworks.

If it isn't wanted, I'll push it into my distribution (Gentoo) as a downstream patch.  But, I have a feeling most distributions will do this, wasting effort.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/#review58731
-----------------------------------------------------------


On May 27, 2014, 1:27 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118340/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 1:27 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled.
> 
> I'm not sure if this is the best way to do this.  If there is any better way, I'll update the patch as appropriate.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 
> 
> Diff: https://git.reviewboard.kde.org/r/118340/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected install directories.  Seems to remove only what is necessary.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140529/b7740b34/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list