Review Request 118389: Fix Compile for kio/src/core/udsentry.cpp on Mac
Allen Winter
winter at kde.org
Thu May 29 12:52:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118389/
-----------------------------------------------------------
(Updated May 29, 2014, 12:52 p.m.)
Review request for KDE Frameworks, David Faure and Mark Gaiser.
Changes
-------
sent last night's patch by mistake. this should be the correct patch now.
Repository: kio
Description
-------
This patch fixes the compile for kio/src/core/udsentry.cpp on Mac, where the stat structure has the st_mtimespec member instead of st_mtim (and st_atimespec instead of st_atim).
We use CMake to set the HAVE_STAT_ST_MTIMESPEC macro, which gets defined (or not) in config-kiocore.h
it also uses st_atimespec (or st_atim) values for setting the USD_ACCESS_TIME. Mark verified this already.
Diffs (updated)
-----
src/core/ConfigureChecks.cmake 472f65f
src/core/config-kiocore.h.cmake 6041c9d
src/core/udsentry.cpp 6ec8e11
Diff: https://git.reviewboard.kde.org/r/118389/diff/
Testing
-------
Still compiles on Linux. Compiles ok on Mac.
Thanks,
Allen Winter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140529/7e900688/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list