Review Request 118374: Fix finding of Qt5LinguistTools on some systems

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118374/#review58678
-----------------------------------------------------------


This review has been submitted with commit 51c4739231a637ee600e21e99e2d0bedb78a99e7 by Alex Merry to branch master.

- Commit Hook


On May 28, 2014, 11:32 a.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118374/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 11:32 a.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Fix finding of Qt5LinguistTools on some systems
> 
> Although ECM does not make use of a compiler directly, the language
> affects the search path for CMake packages; in particular, a package
> installed to /usr/lib64/cmake will not be found if NONE is passed as the
> language argument to project(). This meant that a 64-bit version of
> Qt5LinguistTools would not be found on systems where 64-bit libraries
> are not installed in the "default architecture" location (/usr/lib).
> 
> With this change, the configure step performs some otherwise-unnecessary
> tests. We minimise this by explicitly specifying the C language (which
> is also what some of the tests use), rather than letting it be the
> default (which is C and C++).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 369bc948c606e444ea880a416d8a36606b198f27 
> 
> Diff: https://git.reviewboard.kde.org/r/118374/diff/
> 
> 
> Testing
> -------
> 
> Configures, builds, tests pass, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140528/d8b3af09/attachment.html>