Review Request 118193: Use the macros provided by KDesignerPlugin

[Aurélien Gâteau]

> On May 28, 2014, 2:23 p.m., Aurélien Gâteau wrote:
> > Does not build here: CMake complains that kf5designerplugin_add_plugin() does not exist.
> > 
> > If I replace it with kf5designerplugin_add_widget_files() then it says "Cannot specify link libraries for target "kdedeprecated" which is not built by this project."
> 
> Aurélien Gâteau wrote:
>     Ah, I guess it needs https://git.reviewboard.kde.org/r/118192/
> 
> Alex Merry wrote:
>     Yes. I guess I should say explicitly in the description in future - the "depends on" field is easy to gloss over.

Oh right, I totally missed the field!


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118193/#review58654
-----------------------------------------------------------


On May 18, 2014, 2:13 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118193/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 2:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Use the macros provided by KDesignerPlugin
> 
> This also removes the RPath settings, as they are entirely unnecessary
> (and arguably not correct, since we are linking against a library that
> is locally built).
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6c3a0f3c974c5f48dc8b9a8874440424f0f7d0f0 
> 
> Diff: https://git.reviewboard.kde.org/r/118193/diff/
> 
> 
> Testing
> -------
> 
> Builds, installs, added an arrow button to a form in designer.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140528/8e6533e4/attachment.html>