Review Request 118366: Porting keyboard module to Framework5

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review58618
-----------------------------------------------------------



kcms/keyboard/flags.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40807>

    why not removed?



kcms/keyboard/kcm_keyboard.ui
<https://git.reviewboard.kde.org/r/118366/#comment40808>

    the rename looks unrelated



kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40809>

    coding style: whitespace after for and in front of {



kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40810>

    for new connects I would use the new compile time checked syntax.



kcms/keyboard/kcmmisc.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40811>

    why this commented debug statement?



kcms/keyboard/keyboard_config.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40812>

    remove?



kcms/keyboard/layouts_menu.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40813>

    remove?



kcms/keyboard/xinput_helper.h
<https://git.reviewboard.kde.org/r/118366/#comment40814>

    I think it would have been better to keep the parent argument and pass it to the base QObject



kcms/keyboard/xinput_helper.cpp
<https://git.reviewboard.kde.org/r/118366/#comment40815>

    removing the event doesn't remove the fact that this method is not yet ported. See the #if 0 which indicates that this code has not been adjusted to xcb yet.


- Martin Gräßlin


On May 27, 2014, 11:02 p.m., shivam makkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118366/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 11:02 p.m.)
> 
> 
> Review request for kde-workspace, KDE Frameworks and Andriy Rysin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Removed deprecated statements and ported keyboard module to framework 5.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.cpp 21541e0 
>   kcms/keyboard/flags.cpp b768586 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
>   kcms/keyboard/kcmmisc.h 411bdd2 
>   kcms/keyboard/kcmmisc.cpp 6f787ea 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
>   kcms/keyboard/keyboard_config.cpp f3ff97c 
>   kcms/keyboard/keyboard_daemon.cpp 25673b0 
>   kcms/keyboard/keyboard_hardware.cpp dca49b6 
>   kcms/keyboard/layout_memory.cpp 9e72361 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118a 
>   kcms/keyboard/layouts_menu.cpp fd436c4 
>   kcms/keyboard/xinput_helper.h 343d7ed 
>   kcms/keyboard/xinput_helper.cpp b311579 
> 
> Diff: https://git.reviewboard.kde.org/r/118366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shivam makkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140528/97e93935/attachment.html>