Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

Matthew Dawson matthew at mjdsystems.ca
Tue May 27 18:13:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118359/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kdelibs4support


Description
-------

Change {read,write}Check to *Entry for KUrl and KConfig.

Due to a recent change in KConfig, the {read,write}Check functions were removed,
with the original *Entry functions taking their place.  KUrl overloaded those
functions to allow it to be stored in KConfig.  Fix by using the now generalized
*Entry functions.

Note as those were private functions, KUrl shouldn't have depended upon them.
I'd prefer for KUrl to not overload *Entry functions either, but as it is only
a temporary helper I'm not too worried.

This fixes the broken build described at: http://build.kde.org/job/kdelibs4support_master_qt5/203/


Diffs
-----

  src/kdecore/kconfiggroup_kurl.h 4d7059dba68aff65eb8c0952ccb83d8cc7f35383 

Diff: https://git.reviewboard.kde.org/r/118359/diff/


Testing
-------

Tests pass.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140527/0f3bc16e/attachment.html>


More information about the Kde-frameworks-devel mailing list