Review Request 118289: Change titlewidget from bold to increased font size

Sebastian Kügler sebas at kde.org
Tue May 27 13:55:51 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118289/
-----------------------------------------------------------

(Updated May 27, 2014, 1:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and Christoph Feck.


Repository: kwidgetsaddons


Description
-------

Change titlewidget from bold to increased font size

This patch removes the bold weight from KTitleWidget and makes the text
a bit bigger, improving focus. This is more in line with common
expectations of a title, and it's more in line with Plasma 5's
typography.


Diffs
-----

  src/ktitlewidget.h a0c5641 
  src/ktitlewidget.cpp b1f3ca7 

Diff: https://git.reviewboard.kde.org/r/118289/diff/


Testing
-------

Checked in different systemsettings modules and Kate's dialog. Changed font size in systemsettings -- font and size are correctly updated in the widget layout.


File Attachments
----------------

titlewidget in systemsettings (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png
titlewidget in systemsettings (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png
titlewidget in kate (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png
titlewidget in kate (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png
Example at 1.2x
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/93b91b9b-5c22-42d3-be03-6c30e5709ba3__titlewidget-ss-1.2.png
Example at 1.4x
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/26/3b2b6c38-c431-4a01-be73-3cb4c3c9006e__titlewidget-ss-1.4.png


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140527/0a6655c5/attachment.html>


More information about the Kde-frameworks-devel mailing list