Review Request 118332: Update usage of QVariant::type() for Qt5.

Commit Hook null at kde.org
Mon May 26 19:59:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118332/#review58509
-----------------------------------------------------------


This review has been submitted with commit 8b88eaee8c2db96779bb9a90f52de508b271fe55 by Thomas Braxton to branch master.

- Commit Hook


On May 26, 2014, 6:38 p.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118332/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 6:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> According to http://qt-project.org/doc/qt-5/qvariant.html#type the
> return value of QVariant::type() should be interpreted as a
> QMetaType::Type.
> This also silences the compile-time warnings about 38 not being a member
> of QVariant::Type.
> 
> 
> Diffs
> -----
> 
>   src/core/kconfiggroup.cpp bce9e69d518ce987c4cfaf0f9dd8a2d1cbac6f5b 
> 
> Diff: https://git.reviewboard.kde.org/r/118332/diff/
> 
> 
> Testing
> -------
> 
> All tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140526/3453e79d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list