Review Request 118252: Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118252/
-----------------------------------------------------------

(Updated May 26, 2014, 9:09 a.m.)


Review request for KDE Frameworks, kwin and Eike Hein.


Changes
-------

* dropped the xcb_flush
* added checks for suported WMs to the autotest - at the moment KWin and Openbox whitelisted.


Repository: kwindowsystem


Description
-------

Port KWindowSystem::minimizeWindow and unminizeWindow to XCB

Unit test added to verify that the functionality works correctly.

Note: it uses an Atom instead of xcb_atom_t for WM_CHANGE_STATE as the
create_atoms() function is not yet ported to xcb.


Diffs (updated)
-----

  autotests/kwindowsystemx11test.cpp ec6a574691fd25dde7d02da619cd497bc3660210 
  src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 

Diff: https://git.reviewboard.kde.org/r/118252/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140526/a839f1a9/attachment.html>