Review Request 118039: Simplify KConfig::readEntry/writeEntry

Matthew Dawson matthew at mjdsystems.ca
Mon May 26 06:07:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118039/#review58433
-----------------------------------------------------------

Ship it!


Excellent.  Thanks for the patch!

- Matthew Dawson


On May 26, 2014, 12:52 a.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118039/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:52 a.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This simplifies template<> readEntry/writeEntry by removing unnecessary *Check functions.
> Added kdewin because iirc there was a problem compiling on windows.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 2768318 
>   src/core/kconfiggroup.h 1bcce58 
> 
> Diff: https://git.reviewboard.kde.org/r/118039/diff/
> 
> 
> Testing
> -------
> 
> all tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140526/85b3b135/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list