Review Request 118039: Simplify KConfig::readEntry/writeEntry

[Matthew Dawson]

> On May 7, 2014, 2:12 p.m., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, lines 168-578
> > <https://git.reviewboard.kde.org/r/118039/diff/1/?file=271923#file271923line168>
> >
> >     As below, is this relevant to the simplification?
> 
> Thomas Braxton wrote:
>     yes, they were always supposed to be member functions
> 
> Matthew Dawson wrote:
>     Ok, sounds good.  If the global functions are being deprecated, can you also mark them as such please?  I don't think a SIC is worth that change at this point.

Besides the above point, everything still looks good.  Can you please marks those functions as deprecated?  Afterwards, this looks good to go in.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118039/#review57518
-----------------------------------------------------------


On May 7, 2014, 2:25 p.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118039/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 2:25 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This simplifies template<> readEntry/writeEntry by removing unnecessary *Check functions.
> Added kdewin because iirc there was a problem compiling on windows.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 2768318 
>   src/core/kconfiggroup.h 1bcce58 
> 
> Diff: https://git.reviewboard.kde.org/r/118039/diff/
> 
> 
> Testing
> -------
> 
> all tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140524/0b96a648/attachment-0001.html>