Review Request 118216: Skip non-directory files inside the po/ directory

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118216/
-----------------------------------------------------------

(Updated May 20, 2014, 3:05 p.m.)


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Changes
-------

Reworked the code to also handle empty directories inside the po/ directory. New code does away with the nested 'foreach' blocks. This ensures ecm_process_po_files_as_qm() is always called with valid entries. In the previous code, po_files could be empty, which lead to ecm_process_po_files_as_qm() to fail, complaining about missing value for PO_FILES argument.


Repository: extra-cmake-modules


Description
-------

I had a build failure today because I generated the catalog template (.pot file) in the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot file. Build failed because it tried to find .po files in "po/kwidgetsaddons_qt5.pot/"


Diffs (updated)
-----

  modules/ECMPoQmTools.cmake e217dd3 
  tests/ECMPoQmToolsTest/CMakeLists.txt 3dcb351 

Diff: https://git.reviewboard.kde.org/r/118216/diff/


Testing
-------

kwidgetsaddons now build even if I have a .pot file in there. Added a file to be ignored to the po/ dir of the unit test.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140520/0dab8c23/attachment.html>