Review Request 118217: Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize

Martin Gräßlin mgraesslin at kde.org
Tue May 20 11:55:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118217/
-----------------------------------------------------------

Review request for KDE Frameworks and kwin.


Repository: kwindowsystem


Description
-------

Deprecate the animation argument for KWindowSystem::minimizeWindow and unminimize

If the animation argument was set to false a KWin specific client message
was used. But the implementation was incomplete as it's not part of
_NET_SUPPORTED and by that the implementation does not check whether the
window manager does support this or not.

According to lxr this was only used by SuperKaramba and korgac.


Diffs
-----

  src/kwindowsystem.h 9acf537240967f41f92ce4caa163a380bc2bf945 
  src/kwindowsystem.cpp e93b4c38b485160656d932b326b9416efa484a6f 
  src/kwindowsystem_p.h 925a722a1b5f1736bbbf400983843a2c6f3a3b9c 
  src/kwindowsystem_p_x11.h 6d05775f1f1a5b7ec577533100d39b14eb9f2818 
  src/kwindowsystem_x11.cpp ea11d10b7a3de05464c4066018ca2c96673f6b0d 

Diff: https://git.reviewboard.kde.org/r/118217/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140520/32640b01/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list