Review Request 118195: Look for kded modules without kded_ prefix first

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118195/
-----------------------------------------------------------

(Updated May 19, 2014, 2:39 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Address David's comments.


Repository: kded


Description
-------

Look for kded modules without kded_ prefix first

The implicit kded_ prefix is weird, and contrary to what most other
kservice-based things do. It also means that kded modules cannot
(easily) be placed in a subdirectory of the plugin directory.

The old-style naming is still supported, for compatibility.


Diffs (updated)
-----

  src/kded.cpp 6a3c4935b81ad42324eddc756b24ca85450b8e83 

Diff: https://git.reviewboard.kde.org/r/118195/diff/


Testing
-------

Built, installed. Ran kded5, and made sure
`qdbus org.kde.kded5 /modules/kcookiejar`
still worked (loaded the module etc) with the old-style naming.

Performed the same test after removing the old kded_kcookiejar.so, and installing a modified desktop file with the library set to kf5/kded/kcookiejar, and the kcookiejar module installed as PLUGIN_DIR/kf5/kded/kcookiejar.so (and restarting kded5, of course).


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140519/2c49c774/attachment-0001.html>