Review Request 118195: Look for kded modules without kded_ prefix first

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118195/#review58153
-----------------------------------------------------------


Idea sounds ok, just minor issues.


src/kded.cpp
<https://git.reviewboard.kde.org/r/118195/#comment40422>

    !obj.contains('/') is slightly more readable
    
    Why this test, anyway? I don't really understand the logic here.



src/kded.cpp
<https://git.reviewboard.kde.org/r/118195/#comment40423>

    Won't that warn for every "old style" plugin?
    It's ok to qDebug "using old style naming", but a qWarning annoys the user and the warning text makes it sound like the loading completely failed, even though it will end up working.
    
    I think the qWarning should be out of the loop, when module is null.


- David Faure


On May 18, 2014, 6:54 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118195/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 6:54 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Look for kded modules without kded_ prefix first
> 
> The implicit kded_ prefix is weird, and contrary to what most other
> kservice-based things do. It also means that kded modules cannot
> (easily) be placed in a subdirectory of the plugin directory.
> 
> The old-style naming is still supported, for compatibility.
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp 6a3c4935b81ad42324eddc756b24ca85450b8e83 
> 
> Diff: https://git.reviewboard.kde.org/r/118195/diff/
> 
> 
> Testing
> -------
> 
> Built, installed. Ran kded5, and made sure
> `qdbus org.kde.kded5 /modules/kcookiejar`
> still worked (loaded the module etc) with the old-style naming.
> 
> Performed the same test after removing the old kded_kcookiejar.so, and installing a modified desktop file with the library set to kf5/kded/kcookiejar, and the kcookiejar module installed as PLUGIN_DIR/kf5/kded/kcookiejar.so (and restarting kded5, of course).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140519/e9e82cc4/attachment.html>