Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118200/
-----------------------------------------------------------

(Updated May 19, 2014, 12:07 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Marco Martin.


Repository: knotifications


Description
-------

[StatusNotifier] Don't set custom window flags on ContextMenu

A QMenu has proper default flags with BypassWindowManagerHint.
Thus all the setting of hints and force activate is not needed.
Also it takes care of grabbing keyboard and pointer in this case
resulting in the popup being closed when clicked outside.

This fixes interaction problems with Klipper.


Diffs
-----

  src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 

Diff: https://git.reviewboard.kde.org/r/118200/diff/


Testing
-------

Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140519/0a2d8fe7/attachment.html>