Review Request 118158: Always set src_dir to a not-empty value ('.')

Commit Hook null at kde.org
Sat May 17 00:28:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118158/#review58085
-----------------------------------------------------------


This review has been submitted with commit 759c86400e617f1b776a11b990d383eae38f5c4e by Luigi Toscano to branch master.

- Commit Hook


On May 17, 2014, 12:27 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118158/
> -----------------------------------------------------------
> 
> (Updated May 17, 2014, 12:27 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, Alex Merry, and Aurélien Gâteau.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> src_dir is empty when the current directory contains the docbook the function is working on. But the subsequent globs use its value, so the search pattern is incorrect ('/*.docbook' instead of, after the patch, './*.docbook'), so that docbook and png files are not installed, breaking the help:/ kioslave.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake 08c2a2a 
> 
> Diff: https://git.reviewboard.kde.org/r/118158/diff/
> 
> 
> Testing
> -------
> 
> The missing files are now installed, the examples in tests/ seems to be still working.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140517/9491c116/attachment.html>


More information about the Kde-frameworks-devel mailing list