Review Request 118158: Always set src_dir to a not-empty value ('.')

[Luigi Toscano]

> On May 16, 2014, 11:34 a.m., Alex Merry wrote:
> > KF5DocToolsMacros.cmake, line 96
> > <https://git.reviewboard.kde.org/r/118158/diff/1/?file=273038#file273038line96>
> >
> >     Beware CMake's automatic variable expansion! If the value of ${src_dir} happens to be the name of a variable that expands to the empty string, this will be TRUE.
> >     
> >     Instead, use
> >     if(src_dir STREQUAL "")
> >     or
> >     if(NOT src_dir)

The issue was discussed on IRC and the solution (use src_dir) approved by Alex Merry. I'm going to upload the final patch and commit the review.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118158/#review58047
-----------------------------------------------------------


On May 16, 2014, 1:43 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118158/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1:43 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, Alex Merry, and Aurélien Gâteau.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> src_dir is empty when the current directory contains the docbook the function is working on. But the subsequent globs use its value, so the search pattern is incorrect ('/*.docbook' instead of, after the patch, './*.docbook'), so that docbook and png files are not installed, breaking the help:/ kioslave.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake 08c2a2a 
> 
> Diff: https://git.reviewboard.kde.org/r/118158/diff/
> 
> 
> Testing
> -------
> 
> The missing files are now installed, the examples in tests/ seems to be still working.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140517/b82a9e24/attachment-0001.html>