Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

[Thomas Lübking]

> On May 16, 2014, 1:38 p.m., Thomas Lübking wrote:
> > a) main.cpp, void Application::start()
> > -    Xcb::sync();
> >     owner->claim(m_replace, true);
> > +    Xcb::sync();
> > Sufficient? (though it warns about a QPA crash "later")
> > 
> > b) Qt bug (should flush once per eventcycle) or feature (keeps dirty flag and only flushes on internal need)? -> can such flag be set explicitly?
> 
> Martin Gräßlin wrote:
>     concerning a): no, as it could hit other applications, too.
>     
>     b) I'm not sure whether that's in the scope of Qt. If one goes down towards the lower level one needs to take care of it.

What I meant is: if this is indeed just a bug in Qt, it's probably pointless to fix it here.
If it's a feature (and we've no access to it) it's oc. our duty to make unportable things work.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118167/#review58061
-----------------------------------------------------------


On May 16, 2014, 1 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118167/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 1 p.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Bugs: 334858
>     https://bugs.kde.org/show_bug.cgi?id=334858
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Flush xcb connection after preparing KSelectionOwner::claim
> 
> Without the flush nothing starts. This caused KWin to stall during a
> restart.
> 
> BUG: 334858
> 
> 
> Diffs
> -----
> 
>   src/kselectionowner.cpp 90a0004046135e7fee61fe2ef865b75eb421ea99 
> 
> Diff: https://git.reviewboard.kde.org/r/118167/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140516/67c38fa5/attachment.html>