Review Request 118158: Always set src_dir to a not-empty value ('.')

Luigi Toscano luigi.toscano at tiscali.it
Thu May 15 23:43:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118158/
-----------------------------------------------------------

Review request for Documentation, KDE Frameworks, Alex Merry, and Aurélien Gâteau.


Repository: kdoctools


Description
-------

src_dir is empty when the current directory contains the docbook the function is working on. But the subsequent globs use its value, so the search pattern is incorrect ('/*.docbook' instead of, after the patch, './*.docbook'), so that docbook and png files are not installed, breaking the help:/ kioslave.


Diffs
-----

  KF5DocToolsMacros.cmake 08c2a2a 

Diff: https://git.reviewboard.kde.org/r/118158/diff/


Testing
-------

The missing files are now installed, the examples in tests/ seems to be still working.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140515/86c7f529/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list