Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

Commit Hook null at kde.org
Thu May 15 23:20:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118156/#review58039
-----------------------------------------------------------


This review has been submitted with commit e7f2ed9ac96b1498b30c2e417fc74d9b4785f57a by Aleix Pol to branch master.

- Commit Hook


On May 15, 2014, 3:18 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118156/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 3:18 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> As discussed in https://git.reviewboard.kde.org/r/118149/, it creates inconsistencies. Let's always use it.
> 
> 
> Diffs
> -----
> 
>   KF5DocToolsMacros.cmake ab45ce7 
> 
> Diff: https://git.reviewboard.kde.org/r/118156/diff/
> 
> 
> Testing
> -------
> 
> Makes some builds fail that didn't fail before but were incorrect.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140515/ee87ff6a/attachment.html>


More information about the Kde-frameworks-devel mailing list