Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

[Michael Pyne]

> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote:
> > Note that this broke lots of KAboutData uses.
> > 
> > Please, when doing such changes remember there's things already ported.

Yes, my apologies.

But the pain this change would cause if implemented (and the inconsistent nature of having a KAboutData and K4AboutData both with compatibility members and "KDE5: TODO" comments) is why I brought up the issue to kde-frameworks-devel, why I submitted this RR, why I pinged this RR a few days later after no comments were left, and why I warned in the "Testing Done" part that this would require porting changes downstream in case the description wasn't explicit enough. :-/

It's not my intention to break code (and in fact I can't even take credit for cleaning this code up and marking things as deprecated, I was only trying to remove the stuff already marked to be removed for KF5). Because of SIC none of this can be fixed after KF5.0 is released, so it either had to be done before the release or not done at all. I didn't really care either way, but no one spoke up in favor of "don't do this at all" during the long review and discussion window so....


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57910
-----------------------------------------------------------


On May 13, 2014, 11:52 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117919/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This completes a "KDE5" porting task for KCoreAddons, by moving KAboutData::LicenseKey and KAboutData::NameFormat enums into KAboutLicense.
> 
> This is mostly a mechanical port, however the requirement to keep the deprecated (for KF5) KAboutData ctor requires moving the KAboutLicense class ahead of KAboutData in the header. I wonder why we have this along with K4AboutData however, surely it would make sense to have unported apps simply use that (or declare a license) instead?
> 
> I also removed the deprecated (since KDE 4) single-license accessors since multiple licenses are possible.
> 
> Finally the test suite was updated (a lot of tests relating to single-license calls were removed). If the single-license calls are necessary those can be added back as well but they've been deprecated for awhile, and there is K4AboutData available.
> 
> 
> Diffs
> -----
> 
>   autotests/kaboutdatatest.cpp f4f4f18 
>   src/lib/kaboutdata.h a87141e 
>   src/lib/kaboutdata.cpp 82da19b 
> 
> Diff: https://git.reviewboard.kde.org/r/117919/diff/
> 
> 
> Testing
> -------
> 
> KCoreAddons builds, tests pass, but I would imagine downstream code needs porting after this to fix the naming of the license in its KAboutData ctor.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140515/8d23f875/attachment-0001.html>