Review Request 118127: KDEInstallDirs: fix support for "normal" variables

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118127/
-----------------------------------------------------------

(Updated May 14, 2014, 2:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

If a variable like CMAKE_INSTALL_LIBDIR is defined as a normal variable rather than a cache variable, including KDEInstallDirs fail because it tries to set cache-specific properties on the variable.


Diffs
-----

  kde-modules/KDEInstallDirs.cmake 6102d9e 
  tests/CMakeLists.txt cc11aec 
  tests/KDEInstallDirsTest/CMakeLists.txt PRE-CREATION 
  tests/KDEInstallDirsTest/not_cache_variable/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118127/diff/


Testing
-------

Added test case to reproduce the issue. Does not fail anymore.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140514/8fd46f8a/attachment.html>