Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

[Alex Merry]

> On May 12, 2014, 3:18 p.m., Kevin Ottens wrote:
> > Indeed looks like something which got forgotten along the way. K4About* is supposed to be the porting tool, so let's have this one in even if that's SIC.
> 
> Michael Pyne wrote:
>     To be clear, should I remove the deprecated ctor too, or just the deprecated single-license stuff as in this patch set?
>     
>     Also, the are deprecated catalogName getters/setters too that I missed noticing earlier, but they're marked for KF6 so I'm not proposing to remove those.

The catalogName stuff (including the constructor) I deprecated about a month ago. I didn't remove it in order to keep SC, but if we're breaking that anyway, maybe it makes sense to ditch that stuff as well.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117919/#review57786
-----------------------------------------------------------


On May 1, 2014, 1:03 a.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117919/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 1:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This completes a "KDE5" porting task for KCoreAddons, by moving KAboutData::LicenseKey and KAboutData::NameFormat enums into KAboutLicense.
> 
> This is mostly a mechanical port, however the requirement to keep the deprecated (for KF5) KAboutData ctor requires moving the KAboutLicense class ahead of KAboutData in the header. I wonder why we have this along with K4AboutData however, surely it would make sense to have unported apps simply use that (or declare a license) instead?
> 
> I also removed the deprecated (since KDE 4) single-license accessors since multiple licenses are possible.
> 
> Finally the test suite was updated (a lot of tests relating to single-license calls were removed). If the single-license calls are necessary those can be added back as well but they've been deprecated for awhile, and there is K4AboutData available.
> 
> 
> Diffs
> -----
> 
>   autotests/kaboutdatatest.cpp f4f4f18 
>   src/lib/kaboutdata.h a87141e 
>   src/lib/kaboutdata.cpp 82da19b 
> 
> Diff: https://git.reviewboard.kde.org/r/117919/diff/
> 
> 
> Testing
> -------
> 
> KCoreAddons builds, tests pass, but I would imagine downstream code needs porting after this to fix the naming of the license in its KAboutData ctor.
> 
> 
> Thanks,
> 
> Michael Pyne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140513/c0314438/attachment.html>