Review Request 118098: Guard against empty QStringLists
Kevin Ottens
ervin at kde.org
Mon May 12 15:27:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118098/#review57793
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Ottens
On May 12, 2014, 2:32 p.m., Rohan Garg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118098/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 2:32 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 334650
> https://bugs.kde.org/show_bug.cgi?id=334650
>
>
> Repository: kdelibs4support
>
>
> Description
> -------
>
> Make sure empty string lists are guarded against and join together all entries in the stringlist separated by a ',' separator.
>
>
> Diffs
> -----
>
> src/kssl/kcm/cacertificatespage.cpp 90c757f
>
> Diff: https://git.reviewboard.kde.org/r/118098/diff/
>
>
> Testing
> -------
>
> SSL KCM starts as opposed to crashing earlier.
>
>
> Thanks,
>
> Rohan Garg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140512/e342a075/attachment.html>
More information about the Kde-frameworks-devel
mailing list