Review Request 118084: Move sonnet plugins into kf5/sonnet subdir of plugin install dir

Kevin Ottens ervin at kde.org
Mon May 12 15:24:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118084/#review57792
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On May 11, 2014, 2:48 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118084/
> -----------------------------------------------------------
> 
> (Updated May 11, 2014, 2:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Move sonnet plugins into kf5/sonnet subdir of plugin install dir
> 
> This should help minimise coinstallability issues with KF6.
> 
> 
> Diffs
> -----
> 
>   src/core/loader.cpp 108206088d698dbc67b69d2582fc06145d8c2067 
>   src/plugins/aspell/CMakeLists.txt 4f1828015984e7fd0c07b1870f4f4e7d38ce3210 
>   src/plugins/enchant/CMakeLists.txt e89f0c8225db6d19195eed12284a13d2ac6e9a2d 
>   src/plugins/hspell/CMakeLists.txt 9fde5c4883b9df5efbc645e4c69f839786bd1cc3 
>   src/plugins/hunspell/CMakeLists.txt bac08aa1624bbec1cb1b83e56db159ed54a95c30 
> 
> Diff: https://git.reviewboard.kde.org/r/118084/diff/
> 
> 
> Testing
> -------
> 
> Autotests pass. Inspecting the output of the sonnet-test_core test shows that all the installed plugins are being found.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140512/449e79ca/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list