Review Request 118083: Move theme plugins to kf5/emoticonsthemes subdir of plugins dir

Kevin Ottens ervin at kde.org
Mon May 12 15:24:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118083/#review57791
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Ottens


On May 11, 2014, 2:11 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118083/
> -----------------------------------------------------------
> 
> (Updated May 11, 2014, 2:11 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> -------
> 
> Move theme plugins to kf5/emoticonsthemes subdir of plugins dir
> 
> This should help minimise coinstallability issues with KF6.
> 
> 
> Diffs
> -----
> 
>   src/providers/adium/CMakeLists.txt dbee5e2d5367a75eafcbe193f60b9d278185cec3 
>   src/providers/adium/emoticonstheme_adium.desktop e3502d32c1f54adb04bdd36c699a20c74d349532 
>   src/providers/kde/CMakeLists.txt e475b686b150f3d41141824dbdcba6975a9ac53d 
>   src/providers/kde/emoticonstheme_kde.desktop fe23f7d6c7a09e1e9132b987598ae0364bb4cbec 
>   src/providers/pidgin/CMakeLists.txt 99c5bbcb124847d13eec9cbcd3650bf98b0dd2f0 
>   src/providers/pidgin/emoticonstheme_pidgin.desktop 2dcef956e9c709a552015242943ba5a62ecdfb12 
>   src/providers/xmpp/CMakeLists.txt 6b45c898a783ee04dad53aab8529b1dba5d28630 
>   src/providers/xmpp/emoticonstheme_xmpp.desktop a0cd7b7390c915914aff1ebddfa0c2a497201ed2 
> 
> Diff: https://git.reviewboard.kde.org/r/118083/diff/
> 
> 
> Testing
> -------
> 
> Removed old plugins, build and installed, ran kbuildsycoca5.
> 
> Autotest passed, and manual test listed system-installed emoticon themes.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140512/71c8aa05/attachment.html>


More information about the Kde-frameworks-devel mailing list