Review Request 117695: change where dynamic replace tabs is performed

[Kevin Ottens]

> On May 7, 2014, 1:30 p.m., Sven Brauch wrote:
> > Ping, any new opinions on this?

Looks good to me, but I'd rather see someone more knowledgeable with ktexteditor give the ship it.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695/#review57494
-----------------------------------------------------------


On May 3, 2014, 12:57 a.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117695/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 12:57 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative.
> 
> I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it.
> 
> The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;)
> 
> 
> Diffs
> -----
> 
>   autotests/src/katedocument_test.h cff61d0 
>   autotests/src/katedocument_test.cpp f3eef18 
>   src/document/katedocument.h 83cc031 
>   src/document/katedocument.cpp 546d3e6 
> 
> Diff: https://git.reviewboard.kde.org/r/117695/diff/
> 
> 
> Testing
> -------
> 
> Just some quick manual tests, it seems to still work as intended.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140512/979899f8/attachment-0001.html>