Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

Alex Merry alex.merry at kde.org
Sun May 11 14:00:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118082/
-----------------------------------------------------------

Review request for KDE Frameworks and Alexander Richardson.


Repository: kio


Description
-------

Remove KUrlNavigator tests for ~ and ~username

These depended on a KUriFilter plugin shipped with kio-extras, which
meant the test would fail if that was not installed.

A better approach to this test might be to provide a fake kurifilter
plugin (and use it to test KUriFilter directly), and check that it works
via KUrlNavigator as well.


Diffs
-----

  autotests/kurlnavigatortest.cpp e09944a89c7d2b3ed341003de1bd02ea75293758 

Diff: https://git.reviewboard.kde.org/r/118082/diff/


Testing
-------

The kiowidgets-kurlnavigator test now passes without kio-extras installed.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140511/aca33cdf/attachment.html>


More information about the Kde-frameworks-devel mailing list