Review Request 118077: Fix build of kdelibs4migration.cpp on MSVC2010
David Faure
faure at kde.org
Sun May 11 07:31:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118077/#review57703
-----------------------------------------------------------
Ship it!
Heh, I knew it :)
- David Faure
On May 11, 2014, 12:32 a.m., Nicolás Alvarez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118077/
> -----------------------------------------------------------
>
> (Updated May 11, 2014, 12:32 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> MSVC2010 doesn't support range-based for loops or initializer lists.
> This particular syntax involving QStringLiteral even throws an Internal Compiler Error!
>
>
> Diffs
> -----
>
> src/lib/util/kdelibs4migration.cpp 94655d9
>
> Diff: https://git.reviewboard.kde.org/r/118077/diff/
>
>
> Testing
> -------
>
> Compiles, tests pass.
>
>
> Thanks,
>
> Nicolás Alvarez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140511/210b2275/attachment.html>
More information about the Kde-frameworks-devel
mailing list