Review Request 118069: Fix build of kconfig with recent extra-cmake-modules

Alexander Richardson arichardson.kde at googlemail.com
Sat May 10 13:37:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118069/#review57677
-----------------------------------------------------------


I changed this to build with the version without the prefix added, just revert that if we want to have ecm_add_tests with the prefix

- Alexander Richardson


On May 10, 2014, 3:07 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118069/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 3:07 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> In recent extra-cmake-modules ecm_add_tests prepends prefix name in target name, this fixes the build of kconfig
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 11d98f1 
> 
> Diff: https://git.reviewboard.kde.org/r/118069/diff/
> 
> 
> Testing
> -------
> 
> built, all 32 frameworks failing due to this passes
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140510/598bec22/attachment.html>


More information about the Kde-frameworks-devel mailing list