Review Request 118039: Simplify KConfig::readEntry/writeEntry

[Thomas Braxton]

> On May 7, 2014, 6:12 p.m., Matthew Dawson wrote:
> > Does anyone know the purpose of the *Check functions in the first place?  The change generally seems fine to me otherwise, I'm just not aware of the code history, and git doesn't reveal anything interesting, and I want to avoid rebraking a past fixed issue.

They were added during the merge before 4.0, no idea why. I didn't write them that way.


> On May 7, 2014, 6:12 p.m., Matthew Dawson wrote:
> > src/core/kconfiggroup.h, lines 286-288
> > <https://git.reviewboard.kde.org/r/118039/diff/1/?file=271924#file271924line286>
> >
> >     Please use Q_NULLPTR instead of nullptr, as we still support platforms that don't support nullptr.

oops, not part of simplification


> On May 7, 2014, 6:12 p.m., Matthew Dawson wrote:
> > autotests/kconfigtest.cpp, lines 168-578
> > <https://git.reviewboard.kde.org/r/118039/diff/1/?file=271923#file271923line168>
> >
> >     As below, is this relevant to the simplification?

yes, they were always supposed to be member functions


> On May 7, 2014, 6:12 p.m., Matthew Dawson wrote:
> > src/core/kconfiggroup.h, lines 686-705
> > <https://git.reviewboard.kde.org/r/118039/diff/1/?file=271924#file271924line686>
> >
> >     Are these changes necessary for the simplification?  If not, can this be moved to a separate RR/commit please?

partly yes, will fix


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118039/#review57518
-----------------------------------------------------------


On May 7, 2014, 5:15 p.m., Thomas Braxton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118039/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 5:15 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> This simplifies template<> readEntry/writeEntry by removing unnecessary *Check functions.
> Added kdewin because iirc there was a problem compiling on windows.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigtest.cpp 2768318 
>   src/core/kconfiggroup.h 1bcce58 
> 
> Diff: https://git.reviewboard.kde.org/r/118039/diff/
> 
> 
> Testing
> -------
> 
> all tests still pass.
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140507/9c1dd472/attachment-0001.html>