Review Request 118014: Fix KUrlNavigator returning a http:// URL for absolute file paths
Commit Hook
null at kde.org
Tue May 6 11:27:29 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118014/#review57401
-----------------------------------------------------------
This review has been submitted with commit a2d4a96d5742700d13dabbd2e99609ca54310742 by Alex Richardson to branch master.
- Commit Hook
On May 6, 2014, 10:37 a.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118014/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 10:37 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Previously when entering /home/alex/.config into the dolphin address bar
> which is a KUrlNavigator the result would be http:///home/alex/.config/
>
> It seems the issue was a replacing KUrl(QString) with QUrl(QString) instead
> of QUrl::fromUserInput(QString) in KUriFilter.
>
> Added a unit test to make sure this issue no longer happens
>
>
> Diffs
> -----
>
> autotests/kurlnavigatortest.h f45000fb4ceeea2d74f697610ff748176f95bf9e
> autotests/kurlnavigatortest.cpp 6d178d37ea6ec8131f6507b7191b6ff4b68a4dec
> src/widgets/kurifilter.cpp b307b213da8a2cacb23269943bcc9021e393464e
>
> Diff: https://git.reviewboard.kde.org/r/118014/diff/
>
>
> Testing
> -------
>
> new unit test passes
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140506/632aa782/attachment.html>
More information about the Kde-frameworks-devel
mailing list