Review Request 117997: Fix processing of multiple .po files with the same name

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117997/
-----------------------------------------------------------

(Updated May 6, 2014, 6:45 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
-------

The CMake gettext functions fail when trying to install .po files with the same name. That is, if the directory structure looks like this:

app/
  src/
  po/
    es/
      app.po
    fr/
      app.po
  CMakeLists.txt

If app/CMakeLists.txt calls ki18n_install(po) it fails because gettext_process_po_files() tries to create two rules to turn app.po into app.gmo in the build dir.

This patch work around that issue by copying gettext code from CMake and prepending the language to the name of the .gmo file which is generated in the build dir. I filed a bug and described this workaround on CMake bug tracker ( http://public.kitware.com/Bug/view.php?id=14904 ).

We have the same issue in kdoctools with the kdoctools_install() function, going to fix it as well.


Diffs
-----

  cmake/KF5I18NMacros.cmake 4549fb8 

Diff: https://git.reviewboard.kde.org/r/117997/diff/


Testing
-------

Copied two .po files from l10n-kf5 in kconfigwidgets. Built and installed as expected.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140506/c78f4fb5/attachment.html>