Review Request 118000: Don't use kf5 namespace to search for sonnet_client plugins

Alex Merry alex.merry at kde.org
Mon May 5 16:47:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118000/#review57332
-----------------------------------------------------------


Hmm... I think we still want these in a versioned directory. So instead of this change, the plugins should be installed to ${PLUGIN_INSTALL_DIR}/kf5/sonnet_clients.

Note that the ECM change was to prevent "kf5" being in the path of plugins applications install for themselves (for example, Calligra doesn't want to install its plugins in ${QT_PLUGIN_INSTALL_DIR}/kf5).

- Alex Merry


On May 5, 2014, 3:53 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118000/
> -----------------------------------------------------------
> 
> (Updated May 5, 2014, 3:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> needed so it works correctly with KF5 beta2
> 
> 
> Diffs
> -----
> 
>   src/core/loader.cpp d9096c1 
> 
> Diff: https://git.reviewboard.kde.org/r/118000/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140505/d88abda7/attachment.html>


More information about the Kde-frameworks-devel mailing list