Review Request 117987: Always return true for alphaBlending()

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117987/#review57256
-----------------------------------------------------------

Ship it!


The patch compiles, and non-gui kio clients like kio_info and kio_gopher (which use a KIconLoader) works (tested through kioclient cat).

If no one else objects and this is approved, would you please mention that this setting has not been configurable for a long time as discussed on IRC?

- Luigi Toscano


On May 4, 2014, 4:01 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117987/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 4:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> Using QPixmap::defaultDepth() causes a crash when the icon loader is only used get icon paths and the application is only a QCoreApplication.
> 
> 
> Diffs
> -----
> 
>   src/kiconloader.cpp 501367a 
> 
> Diff: https://git.reviewboard.kde.org/r/117987/diff/
> 
> 
> Testing
> -------
> 
> None, I currently have no KF setup to test.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140504/7cf99be6/attachment.html>