Review Request 117976: Implement support for QFileDialog::setFileMode

David Rosca nowrep at gmail.com
Sat May 3 16:38:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117976/
-----------------------------------------------------------

(Updated May 3, 2014, 4:38 p.m.)


Review request for KDE Frameworks.


Changes
-------

Handle default case in KDEPlatformFileDialog::setFileMode.
Also renamed tests from only testSetMode to testSetFileMode.


Repository: frameworkintegration


Description
-------

This implements support for QFileDialog::setFileMode.
Obsolete value QFileDialog::DirectoryOnly is ignored.

Autotest was added to test all FileModes.


Diffs (updated)
-----

  autotests/kfiledialog_unittest.cpp 69d474c 
  src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 
  src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 

Diff: https://git.reviewboard.kde.org/r/117976/diff/


Testing
-------

The file dialog works as expected, autotests pass.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140503/bd7ddeb6/attachment.html>


More information about the Kde-frameworks-devel mailing list