Review Request 117963: Install the English fallback for license translations, simplify the installation of language-specific files

[Luigi Toscano]

> On May 3, 2014, 4:51 p.m., Alex Merry wrote:
> > common/CMakeLists.txt, lines 14-18
> > <https://git.reviewboard.kde.org/r/117963/diff/1/?file=271204#file271204line14>
> >
> >     Is there any reason why those files wouldn't exist? If not, why the if(EXISTS)?
> >     
> >     Also, the indentation is different to the earlier part of the file.

Right, no reason for checking them.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117963/#review57202
-----------------------------------------------------------


On May 3, 2014, 12:01 a.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117963/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 12:01 a.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> -------
> 
> This is the combination of two commits:
> -- 
> Simplify the installation of language-specific files
> -- 
> Add the English version of license translation file as fallback
>     
> When the -translated version of the license file is available,
> help:/kdoctools5-common/gpl-translated.html always works even
> the translated file for the current language does not exist,
> thanks to kio_help's fallback on the English version.
> 
> 
> Diffs
> -----
> 
>   common/CMakeLists.txt cfdcd71 
> 
> Diff: https://git.reviewboard.kde.org/r/117963/diff/
> 
> 
> Testing
> -------
> 
> Compiles; the old files from common are still installed; copie of the (translatable) licenses are created from the English ones.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140503/da39e968/attachment.html>