Review Request 117961: remove several warnings on mingw

Patrick Spendrin ps_ml at gmx.de
Sat May 3 06:12:16 UTC 2014



> On May 3, 2014, 4:25 a.m., Nicolás Alvarez wrote:
> > src/lib/util/kuser_win.cpp, line 849
> > <https://git.reviewboard.kde.org/r/117961/diff/1/?file=271202#file271202line849>
> >
> >     What's the warning here? Is it about signed vs unsigned? If so, change the format specifier to %u instead of casting.

no, the warning is about DWORD vs. (long) int.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117961/#review57173
-----------------------------------------------------------


On May 2, 2014, 9:16 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117961/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 9:16 p.m.)
> 
> 
> Review request for KDE Frameworks, kdewin and Alexander Richardson.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> remove several warnings on mingw
> 
> 
> Diffs
> -----
> 
>   autotests/kformattest.cpp 7479bb2c2f9730f70831a965f7a03b9e30dd442c 
>   autotests/kprocesstest.cpp 3dbaa9ab3cb238618cae54aed3797c69997aea66 
>   autotests/kusertest.cpp 4ee9e86613bbf7044ac025b128449afeeac00940 
>   src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 
> 
> Diff: https://git.reviewboard.kde.org/r/117961/diff/
> 
> 
> Testing
> -------
> 
> mingw only, needs testing on *nix and on msvc
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140503/2b488f52/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list