Review Request 117952: Fix KIO::suggestName() for the case of leading dots, and no other dot.

Kevin Funk kfunk at kde.org
Fri May 2 16:23:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117952/#review57150
-----------------------------------------------------------

Ship it!


LGTM

- Kevin Funk


On May 2, 2014, 4:12 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117952/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 4:12 p.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Funk.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Fix KIO::suggestName() for the case of leading dots, and no other dot.
> 
> We don't want to change the extension in that case.
> 
> With a unittest for that method, finally.
> 
> 
> Diffs
> -----
> 
>   autotests/globaltest.h b955329cf7d5841d9f9c1230e41d1261a268420e 
>   autotests/globaltest.cpp 4367e53b44e077c566316081e21f429ac15b74a0 
>   src/core/global.cpp b6f523d66ef5b9308f615c485d6dcf3069b26ace 
> 
> Diff: https://git.reviewboard.kde.org/r/117952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140502/e0dd28a3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list