Review Request 117951: trash: Fix KUrl->QUrl porting bug

David Faure faure at kde.org
Fri May 2 16:14:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117951/#review57148
-----------------------------------------------------------

Ship it!


I assume the test failed before the fix, right? ;-)

- David Faure


On May 2, 2014, 4:10 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117951/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 4:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> trash: Fix KUrl->QUrl porting bug
> 
> Make sure we keep the old behavior
> 
> 
> Diffs
> -----
> 
>   trash/tests/testtrash.h f35574d7a18739652545cda751aa925a40bfc5d3 
>   trash/tests/testtrash.cpp 411c7913193dbbb527edfe3601b91dd1f7af99e6 
>   trash/trashimpl.cpp 91c671332dd9545486c2086944c247e0defe8bba 
> 
> Diff: https://git.reviewboard.kde.org/r/117951/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140502/29712b73/attachment.html>


More information about the Kde-frameworks-devel mailing list