Review Request 117799: Clean up private slots in KCompletion

David Gil Oliva davidgiloliva at gmail.com
Thu May 1 21:19:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117799/
-----------------------------------------------------------

(Updated May 1, 2014, 9:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcompletion


Description
-------

Clean up private slots
    
Some private slots didn't have the _k_* form and some methods with the _k_* form weren't even used as slots.


Diffs
-----

  src/kcombobox.h 752db2c 
  src/kcombobox.cpp da31394 
  src/kcompletionbox.h 3295c24 
  src/kcompletionbox.cpp 7d03d64 
  src/khistorycombobox.h ea56358 
  src/khistorycombobox.cpp 9e2f0be 
  src/klineedit.h 705147d 
  src/klineedit.cpp 9d02c12 
  src/klineedit_p.h e544224 

Diff: https://git.reviewboard.kde.org/r/117799/diff/


Testing
-------

It builds. Autotests pass.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140501/8bb035f1/attachment.html>


More information about the Kde-frameworks-devel mailing list