Review Request 117911: ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117911/#review57050
-----------------------------------------------------------


Honestly? I would rather patch (well, script patching) all the frameworks. Especially as we don't have the KF5_ variables separated out into a different InstallDirs file - this is going to affect any KDE software that is not part of KF5 but wants to install a pri file. And are we going to add another variable to check come KF6?

- Alex Merry


On April 30, 2014, 6:49 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117911/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 6:49 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> ECMGeneratePriFile: prefer KF5_INCLUDE_INSTALL_DIR
> 
> This adjusts the generated .pri files so that they have the right include
> dir for frameworks. Testcase: karchive/examples/helloworld
> 
> The alternative is to patch all frameworks...
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake 34001d6cc2791d9b813d9500c392b68a73d9661b 
> 
> Diff: https://git.reviewboard.kde.org/r/117911/diff/
> 
> 
> Testing
> -------
> 
> cd karchive/examples/helloworld ; qmake
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140501/efa56c54/attachment.html>