Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

Commit Hook null at kde.org
Mon Mar 31 22:29:07 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117195/#review54726
-----------------------------------------------------------


This review has been submitted with commit 173cdf21221c5dc91c0afe4205c6d3db28a76559 by Alex Merry to branch master.

- Commit Hook


On March 31, 2014, 2:55 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117195/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 2:55 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Use the new name for the error codes
> 
> ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*.
> 
> 
> Replace COULD_NOT with CANNOT in the error code enum
> 
> This makes the error code names more consistent.  The old versions are
> kept for backwards-compatibility.
> 
> 
> Diffs
> -----
> 
>   src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 
>   src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd 
>   src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 
>   src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 
>   src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 
>   src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 
>   src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 
>   src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de 
>   src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 
>   src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 
> 
> Diff: https://git.reviewboard.kde.org/r/117195/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140331/71465a81/attachment.html>


More information about the Kde-frameworks-devel mailing list