Review Request 117161: Drop QApplication usages in units.cpp
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Mar 30 21:06:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117161/
-----------------------------------------------------------
(Updated March 30, 2014, 9:06 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, Marco Martin and Sebastian Kügler.
Repository: plasma-framework
Description
-------
Drop dependency to QtWidgets from this file. We can start assuming that it might not be that functional in some platforms.
Use QGuiApplication counterparts, based mostly on QScreen, which could make it more powerful in the future.
I did it because otherwise KAlgebraMobile crashes if using the Plasma Components based interface.
Diffs
-----
src/declarativeimports/core/units.cpp f0b8d39
Diff: https://git.reviewboard.kde.org/r/117161/diff/
Testing
-------
Builds, KAlgebra doesn't have the problem now.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140330/7bef4e29/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list