Review Request 117161: Drop QApplication usages in units.cpp

Sebastian Kügler sebas at kde.org
Sun Mar 30 11:54:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117161/#review54589
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On March 29, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117161/
> -----------------------------------------------------------
> 
> (Updated March 29, 2014, 7:25 p.m.)
> 
> 
> Review request for KDE Frameworks, Marco Martin and Sebastian Kügler.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Drop dependency to QtWidgets from this file. We can start assuming that it might not be that functional in some platforms.
> 
> Use QGuiApplication counterparts, based mostly on QScreen, which could make it more powerful in the future.
> 
> I did it because otherwise KAlgebraMobile crashes if using the Plasma Components based interface.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.cpp f0b8d39 
> 
> Diff: https://git.reviewboard.kde.org/r/117161/diff/
> 
> 
> Testing
> -------
> 
> Builds, KAlgebra doesn't have the problem now.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140330/ec68aa07/attachment.html>


More information about the Kde-frameworks-devel mailing list